[
https://issues.apache.org/jira/browse/RATIS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849393#comment-16849393
]
Tsz Wo Nicholas Sze commented on RATIS-568:
-------------------------------------------
[~msingh], thanks for the comments.
> a) GrpcClientProtocolService, responseCompleted can be called in all the
> cases as we should send replies for all the requests which have been
> processed.
For onError, we probably should not call onComplete.
> b) GrpcClientProtocolService:116, so should call onCompleted to complete the
> client stream observer as well.
In the patch, we are passing true to close(boolean) so that it will call
onCompleted.
> Server sliding window should fail out of order requests on close
> ----------------------------------------------------------------
>
> Key: RATIS-568
> URL: https://issues.apache.org/jira/browse/RATIS-568
> Project: Ratis
> Issue Type: Bug
> Components: gRPC
> Reporter: Lokesh Jain
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Attachments: r568_20190524.patch
>
>
> Currently SlidingWindow does not fail the out of order requests on close. The
> out of order requests are not processed and are therefore never removed from
> the queue leading to memory leak. Further OrderedRequestStreamObserver should
> be removed from the orderedStreamObservers map on error or completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
