[
https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851268#comment-16851268
]
Hadoop QA commented on RATIS-571:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 12s{color} | {color:orange} root: The patch generated 1 new + 4 unchanged -
0 fixed = 5 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 25s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-05-29
|
| JIRA Issue | RATIS-571 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970237/RATIS-571.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 8b6d4c83616a 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / b98fac8 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/798/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/798/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/798/testReport/ |
| Max. process+thread count | 2409 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/798/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Client may send first request in sliding window with firstFlag as false
> -----------------------------------------------------------------------
>
> Key: RATIS-571
> URL: https://issues.apache.org/jira/browse/RATIS-571
> Project: Ratis
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-571.001.patch
>
>
> It is possible for the client to send first request in sliding window with
> firstFlag as false.
> In the below example, request with sequence number 73 is accepted in the
> sliding window when the first request is 70. Therefore its first flag is
> false. After that the request with sequence 72 gets a reply from the stream
> observer dc40cfe3. When request 73 is sent to stream observer 87103303 the
> first flag as false and is therefore never processed in the new stream
> observer. It leads to all requests in the server sliding window to be blocked.
>
> {code:java}
> 2019-05-26 11:07:50,532 INFO util.SlidingWindow
> (SlidingWindow.java:sendOrDelayRequest(243)) -
> uid=4272f0d0-95e7-461a-9201-82ddfb218847 request seqNum=73 requestsFirst=70
> firstSeqNum=-1 request=RaftClien
> tRequest:client-DBC1276EA2C1->s0@group-6920A8550E5D, cid=952, seq=73, RW, 3-72
> 2019-05-26 11:07:50,622 INFO util.SlidingWindow
> (SlidingWindow.java:sendRepliesFromHead(439)) -
> dc40cfe3-a06a-43db-893e-e86b0cd41a8b server send reply seq=72
> request=RaftClientRequest:client-DBC1276EA2C1
> ->s1@group-6920A8550E5D, cid=938, seq=72*, RW,
> Message:332d3731:RaftClientReply:client-DBC1276EA2C1->s1@group-6920A8550E5D,
> cid=938, SUCCESS, logIndex=842, commits[s1:c914, s0:c914, s2:c717]
> 2019-05-26 11:07:50,628 DEBUG client.RaftClient
> (RaftClientImpl.java:sendRequestAsync(364)) - client-DBC1276EA2C1: send*
> RaftClientRequest:client-DBC1276EA2C1->s2@group-6920A8550E5D, cid=952,
> seq=73, RW, 3-72
> 2019-05-26 11:07:50,633 INFO util.SlidingWindow
> (SlidingWindow.java:receivedRequest(398)) -
> uid=87103303-ba73-45bf-b2ee-e6c8debf7a25 server received
> request=RaftClientRequest:client-DBC1276EA2C1->s2@group-6920A8550E5D,
> cid=952, seq=73, RW, Message:332d3732:null 13-OrderedRequestStreamObserver13:
> got seq=73 in 13-OrderedRequestStreamObserver13: requests[], nextToProcess=-1
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
