[
https://issues.apache.org/jira/browse/RATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853109#comment-16853109
]
Hadoop QA commented on RATIS-571:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 25s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.examples.arithmetic.TestArithmetic |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-05-31
|
| JIRA Issue | RATIS-571 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970495/RATIS-571.003.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux e6509133b0e3 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / b98fac8 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/809/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/809/testReport/ |
| Max. process+thread count | 2059 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-grpc ratis-test U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/809/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Client may send first request in sliding window with firstFlag as false
> -----------------------------------------------------------------------
>
> Key: RATIS-571
> URL: https://issues.apache.org/jira/browse/RATIS-571
> Project: Ratis
> Issue Type: Bug
> Components: client
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-571.001.patch, RATIS-571.002.patch,
> RATIS-571.003.patch
>
>
> It is possible for the client to send first request in sliding window with
> firstFlag as false.
> In the below example, request with sequence number 73 is accepted in the
> sliding window when the first request is 70. Therefore its first flag is
> false. After that the request with sequence 72 gets a reply from the stream
> observer dc40cfe3. When request 73 is sent to stream observer 87103303 the
> first flag as false and is therefore never processed in the new stream
> observer. It leads to all requests in the server sliding window to be blocked.
>
> {code:java}
> 2019-05-26 11:07:50,532 INFO util.SlidingWindow
> (SlidingWindow.java:sendOrDelayRequest(243)) -
> uid=4272f0d0-95e7-461a-9201-82ddfb218847 request seqNum=73 requestsFirst=70
> firstSeqNum=-1 request=RaftClien
> tRequest:client-DBC1276EA2C1->s0@group-6920A8550E5D, cid=952, seq=73, RW, 3-72
> 2019-05-26 11:07:50,622 INFO util.SlidingWindow
> (SlidingWindow.java:sendRepliesFromHead(439)) -
> dc40cfe3-a06a-43db-893e-e86b0cd41a8b server send reply seq=72
> request=RaftClientRequest:client-DBC1276EA2C1
> ->s1@group-6920A8550E5D, cid=938, seq=72*, RW,
> Message:332d3731:RaftClientReply:client-DBC1276EA2C1->s1@group-6920A8550E5D,
> cid=938, SUCCESS, logIndex=842, commits[s1:c914, s0:c914, s2:c717]
> 2019-05-26 11:07:50,628 DEBUG client.RaftClient
> (RaftClientImpl.java:sendRequestAsync(364)) - client-DBC1276EA2C1: send*
> RaftClientRequest:client-DBC1276EA2C1->s2@group-6920A8550E5D, cid=952,
> seq=73, RW, 3-72
> 2019-05-26 11:07:50,633 INFO util.SlidingWindow
> (SlidingWindow.java:receivedRequest(398)) -
> uid=87103303-ba73-45bf-b2ee-e6c8debf7a25 server received
> request=RaftClientRequest:client-DBC1276EA2C1->s2@group-6920A8550E5D,
> cid=952, seq=73, RW, Message:332d3732:null 13-OrderedRequestStreamObserver13:
> got seq=73 in 13-OrderedRequestStreamObserver13: requests[], nextToProcess=-1
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
