[
https://issues.apache.org/jira/browse/RATIS-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891865#comment-16891865
]
Lokesh Jain commented on RATIS-628:
-----------------------------------
[~szetszwo] Thanks for working on this! The patch looks good to me. There are
few test failures and a checkstyle issue. Can you please take a look? The test
failures do not seem to be related.
> Simplify the code in LogSegment
> -------------------------------
>
> Key: RATIS-628
> URL: https://issues.apache.org/jira/browse/RATIS-628
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: r628_20190719.patch
>
>
> This is a followup on RATIS-625. This JIRE is to simplify the code in
> LogSegment:
> - LogRecordWithEntry can be removed.
> - hasEntryCache can be removed.
> - appendToOpenSegment should take only a single LogEntryProto parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
