[ 
https://issues.apache.org/jira/browse/RATIS-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892068#comment-16892068
 ] 

Tsz Wo Nicholas Sze commented on RATIS-628:
-------------------------------------------

Thanks, [~ljain].  I was avoiding changing the indentation so that it leaded to 
the checkstyle issue.

r628_20190724.patch: fixes checkstyle warning 

> Simplify the code in LogSegment
> -------------------------------
>
>                 Key: RATIS-628
>                 URL: https://issues.apache.org/jira/browse/RATIS-628
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: r628_20190719.patch, r628_20190724.patch
>
>
> This is a followup on RATIS-625.  This JIRE is to simplify the code in 
> LogSegment:
> - LogRecordWithEntry can be removed.
> - hasEntryCache can be removed.
> - appendToOpenSegment should take only a single LogEntryProto parameter.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to