[
https://issues.apache.org/jira/browse/RATIS-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939285#comment-16939285
]
Tsz-wo Sze commented on RATIS-678:
----------------------------------
Sorry for commenting this late:
- server.getMemberId().getGroupId() is a cheaper then
server.getGroup().getGroupId() since server.getGroup() needs to construct the
peer list, which is expensive.
- How about combining notifyLeader(..) and notifyLeaderChanged(..) to a single
method?
> Notify Leader does not provide raft group id
> --------------------------------------------
>
> Key: RATIS-678
> URL: https://issues.apache.org/jira/browse/RATIS-678
> Project: Ratis
> Issue Type: Improvement
> Components: raft-group
> Affects Versions: 0.4.0
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: RATIS-678.01.patch, RATIS-678.02.patch,
> RATIS-678.03.patch
>
>
> org.apache.ratis.statemachine.StateMachine#notifyLeader
> does not provide the group id for which leader election is complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
