[jira] [Commented] (RATIS-773) Fix checkstyle violations in ratis-server

[Lokesh Jain (Jira)]

    [ 
https://issues.apache.org/jira/browse/RATIS-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079235#comment-17079235
 ] 

Lokesh Jain commented on RATIS-773:
-----------------------------------

[~dineshchitlangia] Thanks for working on this! The changes look good to me. 
Please find my comments below.
 # LeaderElection#askForVotes, LogAppender#handleReply - We can throw an 
Exception in the default case.
 # RaftServerImpl#submitClientRequestAsync, applyLogToStateMachine - We can 
avoid tthe get call and use the stateMachine field itself.
{code:java}
final StateMachine stMachine = getStateMachine();{code}

> Fix checkstyle violations in ratis-server
> -----------------------------------------
>
>                 Key: RATIS-773
>                 URL: https://issues.apache.org/jira/browse/RATIS-773
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: RATIS-773.001.patch
>
>
> Fix checkstyle violations in ratis-server module



--
This message was sent by Atlassian Jira
(v8.3.4#803005)