[
https://issues.apache.org/jira/browse/RATIS-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079545#comment-17079545
]
Dinesh Chitlangia commented on RATIS-773:
-----------------------------------------
[~ljain] thanks for reviewing. Patch 002 addresses review comments.
TestCacheEviction failure, it was due to LogSegment class being made final.
Mockito-1.x cannot spy on final classes.
The feature is available in Mockito-2.x but we do not yet have a stable
release. So I have added a TODO note in LogSegment explaining why we are not
making the class final to address the checktyle issue.
> Fix checkstyle violations in ratis-server
> -----------------------------------------
>
> Key: RATIS-773
> URL: https://issues.apache.org/jira/browse/RATIS-773
> Project: Ratis
> Issue Type: Sub-task
> Components: server
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: RATIS-773.001.patch, RATIS-773.002.patch
>
>
> Fix checkstyle violations in ratis-server module
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
