[
https://issues.apache.org/jira/browse/ROCKETMQ-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223304#comment-16223304
]
ASF GitHub Bot commented on ROCKETMQ-306:
-----------------------------------------
aCoder2013 opened a new pull request #187: [ROCKETMQ-306] Improve thread name
URL: https://github.com/apache/rocketmq/pull/187
## What is the purpose of the change
Assign a name of thread created by checkExecutor to help tracing errors,eg:
jstack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Specify thread's name of DefaultMQProducerImpl's checkExecutor
> --------------------------------------------------------------
>
> Key: ROCKETMQ-306
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-306
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Reporter: acoder2014
> Assignee: Xiaorui Wang
> Priority: Critical
>
> Current the way of initializing checkExecutor didn't specify a threadFactory
> with provided a meaningful thread name which is very helpful to trace the
> error information,so we better assign a name of this thread pool.
> {code:java}
> this.checkExecutor = new ThreadPoolExecutor(
> producer.getCheckThreadPoolMinSize(),
> producer.getCheckThreadPoolMaxSize(),
> 1000 * 60,
> TimeUnit.MILLISECONDS,
> this.checkRequestQueue);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
