[
https://issues.apache.org/jira/browse/ROCKETMQ-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223318#comment-16223318
]
ASF GitHub Bot commented on ROCKETMQ-306:
-----------------------------------------
coveralls commented on issue #187: [ROCKETMQ-306] Improve thread name
URL: https://github.com/apache/rocketmq/pull/187#issuecomment-340158624
[](https://coveralls.io/builds/13932436)
Coverage decreased (-0.01%) to 39.211% when pulling
**00092b6b78e1ad52123c3164d67220315fea87bf on aCoder2013:assign-thread-name**
into **1a88fe09757969a0c8e53b8ddb793ff449aeae25 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Specify thread's name of DefaultMQProducerImpl's checkExecutor
> --------------------------------------------------------------
>
> Key: ROCKETMQ-306
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-306
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Reporter: acoder2014
> Assignee: Xiaorui Wang
> Priority: Critical
>
> Current the way of initializing checkExecutor didn't specify a threadFactory
> with provided a meaningful thread name which is very helpful to trace the
> error information,so we better assign a name of this thread pool.
> {code:java}
> this.checkExecutor = new ThreadPoolExecutor(
> producer.getCheckThreadPoolMinSize(),
> producer.getCheckThreadPoolMaxSize(),
> 1000 * 60,
> TimeUnit.MILLISECONDS,
> this.checkRequestQueue);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
