[ 
https://issues.apache.org/jira/browse/ROCKETMQ-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383440#comment-16383440
 ] 

ASF GitHub Bot commented on ROCKETMQ-319:
-----------------------------------------

fuyou001 commented on a change in pull request #205: [ROCKETMQ-319] improve 
broker register performance and reduce memory usage  
URL: https://github.com/apache/rocketmq/pull/205#discussion_r171815571
 
 

 ##########
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -245,7 +245,7 @@ private RemotingCommand 
updateAndCreateTopic(ChannelHandlerContext ctx,
         topicConfig.setTopicSysFlag(requestHeader.getTopicSysFlag() == null ? 
0 : requestHeader.getTopicSysFlag());
 
         
this.brokerController.getTopicConfigManager().updateTopicConfig(topicConfig);
-        this.brokerController.registerBrokerAll(false, true);
+        this.brokerController.registerBrokerAll(false, true,true);
 
 Review comment:
   format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> improve broker register performance and reduce memory usage
> -----------------------------------------------------------
>
>                 Key: ROCKETMQ-319
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-319
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker, rocketmq-namesrv
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>            Reporter: yubaofu
>            Assignee: yukon
>            Priority: Major
>
> when MQ broker cluster manage topic size very large, eg 10,000+,when MQ 
> Broker register meta info to name server,cause mq broker gc problem,so we 
> fixed it . 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to