[ 
https://issues.apache.org/jira/browse/ROCKETMQ-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387188#comment-16387188
 ] 

ASF GitHub Bot commented on ROCKETMQ-319:
-----------------------------------------

zhouxinyu commented on a change in pull request #205: [ROCKETMQ-319] improve 
broker register performance and reduce memory usage  
URL: https://github.com/apache/rocketmq/pull/205#discussion_r172395989
 
 

 ##########
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
 ##########
 @@ -52,6 +62,8 @@
     private final RemotingClient remotingClient;
     private final TopAddressing topAddressing = new 
TopAddressing(MixAll.getWSAddr());
     private String nameSrvAddr = null;
+    private BrokerFixedThreadPoolExecutor brokerOuterExecutor = new 
BrokerFixedThreadPoolExecutor(4, 10, 1, TimeUnit.MINUTES,
 
 Review comment:
   This executor should be shut down when exists broker~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> improve broker register performance and reduce memory usage
> -----------------------------------------------------------
>
>                 Key: ROCKETMQ-319
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-319
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker, rocketmq-namesrv
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>            Reporter: yubaofu
>            Assignee: yukon
>            Priority: Major
>
> when MQ broker cluster manage topic size very large, eg 10,000+,when MQ 
> Broker register meta info to name server,cause mq broker gc problem,so we 
> fixed it . 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to