[
https://issues.apache.org/jira/browse/ROCKETMQ-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780725#comment-15780725
]
ASF GitHub Bot commented on ROCKETMQ-20:
----------------------------------------
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/18
[ROCKETMQ-20] Default 'consumeFromWhere' is inconsist with example's
The example pull consumer has a line code like this:
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
This is not necessary for a minimum viable pull consumer.
If this line is important, then it should be the default value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-20
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit c7f4da7cdb1f55e663b5ab284fb40b53c3ce651a
Author: dongeforever <[email protected]>
Date: 2016-12-27T16:19:05Z
ROCKETMQ-20 default 'consumeFromWhere' is inconsist with example's
----
> Default 'consumeFromWhere' is inconsist with example's
> ------------------------------------------------------
>
> Key: ROCKETMQ-20
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-20
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: zander
> Assignee: vongosling
> Labels: easyfix
> Fix For: 4.0.0-incubating
>
>
> The example pull consumer has a line code like this:
> consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
> This is not necessary for a minimum viable pull consumer.
> If this line is important, then it should be the default value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
