[ 
https://issues.apache.org/jira/browse/ROCKETMQ-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784728#comment-15784728
 ] 

ASF GitHub Bot commented on ROCKETMQ-20:
----------------------------------------

Github user lollipopjin commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/18
  
    @dongeforever Thanks for you PR, we will add some notes in the example to 
eliminate confuse. :-) 


> Default 'consumeFromWhere' is inconsist with example's
> ------------------------------------------------------
>
>                 Key: ROCKETMQ-20
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-20
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: zander
>            Assignee: vongosling
>              Labels: easyfix
>             Fix For: 4.0.0-incubating
>
>
> The example pull consumer  has a line code like this:
> consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
> This is not necessary for a minimum viable pull consumer.
> If this line is important, then it should be the default value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to