[
https://issues.apache.org/jira/browse/ROCKETMQ-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799993#comment-15799993
]
ASF GitHub Bot commented on ROCKETMQ-30:
----------------------------------------
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/27
[ROCKETMQ-30] Fixed method signature for Message Filter example and c…
…lass loading from resources/
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-30
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit fd99f12c32d2c44400c45ce5b53903b1f78558c5
Author: shtykh_roman <[email protected]>
Date: 2017-01-05T01:58:50Z
[ROCKETMQ-30] Fixed method signature for Message Filter example and class
loading from resources/
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30
----
> Message Filter example has incorrect method signature
> -----------------------------------------------------
>
> Key: ROCKETMQ-30
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-30
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> {{org.apache.rocketmq.example.filter.MessageFilterImpl}} has {{public boolean
> match(MessageExt msg)}} while the correct one is {{public boolean
> match(MessageExt msg, FilterContext context)}}. Therefore it fails to compile
> and load with {{DynaCode}}.
> Additionally, {{org.apache.rocketmq.example.filter.Consumer}} refers to the
> path that normally may not exist on users' machines {{/home/admin/}}. It
> should be changed to the {{resources/}} where {{MessageFilterImpl}} is placed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
