[ 
https://issues.apache.org/jira/browse/ROCKETMQ-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811048#comment-15811048
 ] 

ASF subversion and git services commented on ROCKETMQ-30:
---------------------------------------------------------

Commit 1562bd0d11fbf4bbbca38921c6cc07ebe11ea15a in incubator-rocketmq's branch 
refs/heads/master from shroman
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=1562bd0 ]

[ROCKETMQ-30] Fixed method signature for Message Filter example and class 
loading from resources, closes apache/incubator-rocketmq#27


> Message Filter example has incorrect method signature
> -----------------------------------------------------
>
>                 Key: ROCKETMQ-30
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-30
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> {{org.apache.rocketmq.example.filter.MessageFilterImpl}} has {{public boolean 
> match(MessageExt msg)}} while the correct one is {{public boolean 
> match(MessageExt msg, FilterContext context)}}. Therefore it fails to compile 
> and load with {{DynaCode}}.
> Additionally, {{org.apache.rocketmq.example.filter.Consumer}} refers to the 
> path that normally may not exist on users' machines {{/home/admin/}}. It 
> should be changed to the {{resources/}} where {{MessageFilterImpl}} is placed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to