[
https://issues.apache.org/jira/browse/ROCKETMQ-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811107#comment-15811107
]
ASF GitHub Bot commented on ROCKETMQ-37:
----------------------------------------
GitHub user a2888409 opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/33
[ROCKETMQ-37] Log output information is not accurate
Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-37
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/a2888409/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 633eca2665edca4999b28f3f57857649d821c52c
Author: qianzhenyu <[email protected]>
Date: 2017-01-09T08:54:31Z
Fix-37 [ROCKETMQ-37] Log output information is not accurate
----
> Log output information is not accurate
> --------------------------------------
>
> Key: ROCKETMQ-37
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-37
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: QianZhenyu
> Assignee: vongosling
>
> 1. in MQClientManager#getAndCreateMQClientInstance line 57
> when generate a new key-value pair for client in factoryTable, if there
> was no mapping for the clientId previously, putIfAbsent will return null, and
> then output:
> "log.warn("Previous MQClientInstance has created for clientId:[{}]",
> clientId);"
> this is wrong, it should output in condition prev != null
> 2. in SubscriptionGroupManager#deleteSubscriptionGroupConfig line 187
> if program execute:
> log.warn("delete subscription group failed, subscription group: {} not
> exist", old);
> variable old is always null , it's useless, so it's better to print groupName
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
