[
https://issues.apache.org/jira/browse/ROCKETMQ-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831312#comment-15831312
]
ASF subversion and git services commented on ROCKETMQ-37:
---------------------------------------------------------
Commit 69361f60b70436996e3479e2ed4473f4f1ca2af1 in incubator-rocketmq's branch
refs/heads/ROCKETMQ-57 from [~qianzhenyu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=69361f6 ]
[ROCKETMQ-37] Polish log output information in MQClientManager, closes
apache/incubator-rocketmq#33, closes apache/incubator-rocketmq#26
> Log output information is not accurate
> --------------------------------------
>
> Key: ROCKETMQ-37
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-37
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: QianZhenyu
> Assignee: vongosling
>
> 1. in MQClientManager#getAndCreateMQClientInstance line 57
> when generate a new key-value pair for client in factoryTable, if there
> was no mapping for the clientId previously, putIfAbsent will return null, and
> then output:
> "log.warn("Previous MQClientInstance has created for clientId:[{}]",
> clientId);"
> this is wrong, it should output in condition prev != null
> 2. in SubscriptionGroupManager#deleteSubscriptionGroupConfig line 187
> if program execute:
> log.warn("delete subscription group failed, subscription group: {} not
> exist", old);
> variable old is always null , it's useless, so it's better to print groupName
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
