[
https://issues.apache.org/jira/browse/ROCKETMQ-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823426#comment-15823426
]
ASF GitHub Bot commented on ROCKETMQ-59:
----------------------------------------
GitHub user iskl opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/43
[ROCKETMQ-59] Change Charset usages in RocketMQSerializable to Rocket…
The PR is to resolve
[issue-59](https://issues.apache.org/jira/browse/ROCKETMQ-59)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iskl/incubator-rocketmq ROCKETMQ-59
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 5358cc2de6bb32a0aa4afed18c342f618f000b75
Author: Kailai Shao <[email protected]>
Date: 2017-01-16T03:57:19Z
[ROCKETMQ-59] Change Charset usages in RocketMQSerializable to
RocketMQSerializable#CHARSET_UTF8
----
> Charset misusage in RocketMQSerializable
> ----------------------------------------
>
> Key: ROCKETMQ-59
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-59
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-remoting
> Affects Versions: 4.1.0-incubating
> Reporter: Kailai Shao
> Assignee: vongosling
> Fix For: 4.1.0-incubating
>
>
> When writing unit tests for rocketmq-remoting, I found that
> {{RocketMQSerializable}} misused the charset for {{RemotingSerializable}}.
> Go into details. The class {{RemotingCommand}} has two formats to serialize
> its header: JSON format (source code {{RemotingSerializable.java}}) and
> ROCKETMQ (source code {{RocketMQSerializable.java}}) format, respectively.
> Both formats have their own encode method, decode method and charset. But
> methods in {{RocketMQSerializable.java}} use the charset for
> {{RemotingSerializable.java}}.
> Although two charsets are both UTF-8 thus no problem occurs so far, but it's
> better to modify to make the code commonsensible :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
