[
https://issues.apache.org/jira/browse/ROCKETMQ-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831314#comment-15831314
]
ASF subversion and git services commented on ROCKETMQ-59:
---------------------------------------------------------
Commit 457bb61f0489d58c810330b40c62ccb7e75b602b in incubator-rocketmq's branch
refs/heads/ROCKETMQ-57 from [~kailai]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=457bb61 ]
[ROCKETMQ-59] Change Charset usages in RocketMQSerializable to
RocketMQSerializable#CHARSET_UTF8, closes apache/incubator-rocketmq#43
> Charset misusage in RocketMQSerializable
> ----------------------------------------
>
> Key: ROCKETMQ-59
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-59
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-remoting
> Affects Versions: 4.1.0-incubating
> Reporter: Kailai Shao
> Assignee: vongosling
> Priority: Minor
> Fix For: 4.1.0-incubating
>
>
> When writing unit tests for rocketmq-remoting, I found that
> {{RocketMQSerializable}} misused the charset for {{RemotingSerializable}}.
> Go into details. The class {{RemotingCommand}} has two formats to serialize
> its header: JSON format (source code {{RemotingSerializable.java}}) and
> ROCKETMQ (source code {{RocketMQSerializable.java}}) format, respectively.
> Both formats have their own encode method, decode method and charset. But
> methods in {{RocketMQSerializable.java}} use the charset for
> {{RemotingSerializable.java}}.
> Although two charsets are both UTF-8 thus no problem occurs so far, but it's
> better to modify to make the code commonsensible :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
