[
https://issues.apache.org/jira/browse/ROCKETMQ-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834297#comment-15834297
]
ASF GitHub Bot commented on ROCKETMQ-72:
----------------------------------------
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/49
[ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when fa…
…iled in the middle of start()
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
Setting `shutdown` to `false` doesn't seem semantically very correct to me,
but without it, message store cannot be properly shutdown.
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-72
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 2b15a5a72c16aa82070f940cf7d329a7460a2c92
Author: shtykh_roman <[email protected]>
Date: 2017-01-23T11:27:00Z
[ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when failed
in the middle of start()
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
----
> DefaultMessageStore cannot be properly shutdown when failed in the middle of
> start()
> ------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-72
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-72
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Critical
>
> If {{DefaultMessageStore#start}} fails before it reaches {{this.shutdown =
> false;}} it remains _true_ and prevents proper shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
