[
https://issues.apache.org/jira/browse/ROCKETMQ-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882314#comment-15882314
]
ASF GitHub Bot commented on ROCKETMQ-72:
----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/49
@zhouxinyu I guess you are talking about a shutdown hook that calls
`shutdown()`. But the problem remains -- imagine `start()` fails in the middle
and even if `shutdown()` is called, no proper termination is done because
`this.shutdown` is `true`.
> DefaultMessageStore cannot be properly shutdown when failed in the middle of
> start()
> ------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-72
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-72
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Critical
>
> If {{DefaultMessageStore#start}} fails before it reaches {{this.shutdown =
> false;}} it remains _true_ and prevents proper shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
