[jira] [Commented] (ROCKETMQ-102) When shutdown(), the persisted offet is not the latest consumed message, which may cause repeated messages

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872111#comment-15872111
 ] 

ASF GitHub Bot commented on ROCKETMQ-102:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/64
  
    
    [![Coverage 
Status](https://coveralls.io/builds/10206021/badge)](https://coveralls.io/builds/10206021)
    
    Coverage increased (+0.5%) to 31.992% when pulling 
**b178d2fb1c138b8f89d8d670ee39daa96c72a2d1 on 
Jaskey:ROCKETMQ-102-shutdown-await** into 
**573b22c37806a21543b90707bcce6022243a62da on apache:master**.



> When shutdown(), the persisted offet is not the latest consumed message, 
> which may cause repeated messages
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-102
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-102
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client
>            Reporter: Jaskey Lam
>            Assignee: Xiaorui Wang
>
> When shutdown push consumer, push consumer will shutdwon thread pool then 
> persist offset.
> While shutdown thread pool is only stop submiting message to consume, which 
> does not stop consuming message which exists in the the thread queue or is 
> already being consumed.
> Which will cause repeated message very easily though user are shutdown 
> gracefully according to the provided interface.
> A way to solve this problem is needed. Such as accpet a param that how long 
> to wait for thread pool to terminated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)