[
https://issues.apache.org/jira/browse/ROCKETMQ-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882160#comment-15882160
]
ASF GitHub Bot commented on ROCKETMQ-102:
-----------------------------------------
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/64#discussion_r102893082
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java
---
@@ -52,6 +56,7 @@
import org.apache.rocketmq.common.protocol.header.PullMessageRequestHeader;
import org.apache.rocketmq.remoting.exception.RemotingException;
import org.junit.After;
+import org.junit.Assert;
--- End diff --
Hi, let's unify the assert tool and use
`org.assertj.core.api.Assertions.assertThat`.
> When shutdown(), the persisted offet is not the latest consumed message,
> which may cause repeated messages
> ----------------------------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-102
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-102
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Xiaorui Wang
>
> When shutdown push consumer, push consumer will shutdwon thread pool then
> persist offset.
> While shutdown thread pool is only stop submiting message to consume, which
> does not stop consuming message which exists in the the thread queue or is
> already being consumed.
> Which will cause repeated message very easily though user are shutdown
> gracefully according to the provided interface.
> A way to solve this problem is needed. Such as accpet a param that how long
> to wait for thread pool to terminated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
