[
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968535#comment-15968535
]
ASF GitHub Bot commented on ROCKETMQ-174:
-----------------------------------------
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
1) This project is still at incubation stage, if we do not correct things
now, we may never ever get the chance to fix them afterwards.
2) Transaction related feature is not currently implemented, IMO, we may
fix this interface before it's widely used.
> Spelling Fix
> ------------
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
> Priority: Trivial
> Time Spent: 168h
> Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
