[
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968556#comment-15968556
]
ASF GitHub Bot commented on ROCKETMQ-174:
-----------------------------------------
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
This is why I make these changes thorough PR process instead of regarding
them trivial and merging directly.
We can discuss to figure out an acceptable way.
You may also notice that I do not change configuration name spelling issues
yet and I am expecting opinions too.
> Spelling Fix
> ------------
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
> Priority: Trivial
> Time Spent: 168h
> Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)