[ 
https://issues.apache.org/jira/browse/ROCKETMQ-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978432#comment-15978432
 ] 

ASF GitHub Bot commented on ROCKETMQ-187:
-----------------------------------------

GitHub user dongeforever opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/96

    [ROCKETMQ-187]Measure the code coverage for Integration Tests, and add 
sonar-apache profile

    https://issues.apache.org/jira/browse/ROCKETMQ-187
    
    Now we could browse the Unit Tests and IT Tests at 
    
https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all
    But the IT Test coverage is not correct. It should cover the original 
sources instead of the the classes in test module.
    As for as I known, the coverage report is generated by matching the 
collected data(often using java agent) against a set of classes (the module 
classes compiled from src/main/). you could refer to: 
http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/
    So we could match the jacoco-it.exec to each module's source classes to get 
the correct IT coverage report.
    By the way, we'd better exclude the classes in the test module.
    
    
    we may use sonar locally.  
    So we'd better use profile to handle different occasions


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongeforever/incubator-rocketmq IT_POLISH

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit d7a155a4e8d66f20ff4ca4dca55368b593185e9c
Author: dongeforever <[email protected]>
Date:   2017-04-18T12:42:29Z

    Revise IT code coverage, add sonar-apache profile

----


> Measure the code coverage for Integration Tests
> -----------------------------------------------
>
>                 Key: ROCKETMQ-187
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-187
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: dongeforever
>            Assignee: dongeforever
>
> Now we could browse the Unit Tests and IT Tests at 
> https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all
> But the IT Test coverage is not correct. It should cover the original sources 
> instead of the the classes in test module.
> As for as I known, the coverage report  is generated by matching the 
> collected data(often using java agent) against a set of classes (the module 
> classes compiled from src/main/). you could refer to: 
> http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/
> So we could match the jacoco-it.exec to each module's source classes to get 
> the correct IT coverage report.
> By the way, we'd better exclude the classes in the test module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to