[
https://issues.apache.org/jira/browse/ROCKETMQ-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982357#comment-15982357
]
ASF GitHub Bot commented on ROCKETMQ-188:
-----------------------------------------
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/98
[ROCKETMQ-188]RemotingExecption is not consistent between invoke async and
invoke oneway
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-188
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jaskey/incubator-rocketmq
ROCKETMQ-188-remoting-exception-inconsistent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit ec2d4ac140fab8812066a7184f9e21ea0b879191
Author: Jaskey <[email protected]>
Date: 2017-04-25T03:00:51Z
Make exception of invokeAsync is consitent of invokeOneway
----
> RemotingExecption is not consistent between invoke async and invoke oneway
> --------------------------------------------------------------------------
>
> Key: ROCKETMQ-188
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-188
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-remoting
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
> Priority: Minor
>
> For existing invoke oneway code base, RemotingTooMuchRequestException will be
> thrown only when timeout millis <0, otherwise, RemotingTimeoutException will
> be thrown.
> But in invokeAsync, RemotingTooMuchRequestException is always thrown no
> matter what value the timeout millis , which is inconsistent. Besides, the
> RemotingTimeoutException is declared in the signature but it will be never
> thrown.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
