[jira] [Commented] (ROCKETMQ-188) RemotingExecption is not consistent between invoke async and invoke oneway

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982366#comment-15982366
 ] 

ASF GitHub Bot commented on ROCKETMQ-188:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/98
  
    
    [![Coverage 
Status](https://coveralls.io/builds/11225316/badge)](https://coveralls.io/builds/11225316)
    
    Coverage increased (+0.04%) to 37.893% when pulling 
**ec2d4ac140fab8812066a7184f9e21ea0b879191 on 
Jaskey:ROCKETMQ-188-remoting-exception-inconsistent** into 
**6a9628b3c3e6835e37baf7b58ad9300364d4d384 on apache:develop**.



> RemotingExecption is not consistent between invoke async and invoke oneway
> --------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-188
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-188
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-remoting
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>
> For existing invoke oneway code base, RemotingTooMuchRequestException will be 
> thrown only when timeout millis <0, otherwise, RemotingTimeoutException will 
> be thrown.
> But in invokeAsync, RemotingTooMuchRequestException is always thrown no 
> matter what value the timeout millis , which is inconsistent. Besides, the 
> RemotingTimeoutException is declared in the signature but it will be never 
> thrown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)