[jira] [Commented] (ROCKETMQ-215) Use java 7 syntax to refator code base

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040628#comment-16040628
 ] 

ASF GitHub Bot commented on ROCKETMQ-215:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/117
  
    
    [![Coverage 
Status](https://coveralls.io/builds/11864245/badge)](https://coveralls.io/builds/11864245)
    
    Coverage increased (+0.5%) to 39.145% when pulling 
**38764652b24992d839eab4c2cb50940a473e40f4 on dzyangxi:develop** into 
**80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop**.



> Use java 7 syntax to refator code base
> --------------------------------------
>
>                 Key: ROCKETMQ-215
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-215
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-broker, rocketmq-namesrv, rocketmq-store
>            Reporter: Jaskey Lam
>            Assignee: yukon
>            Priority: Minor
>
> code base may have some code like 
> {code}
>     private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer, 
> Long>> offsetTable =
>         new ConcurrentHashMap<String, ConcurrentMap<Integer, Long>>(512);
> {code}
> Atucally, with java7, it can be simplied to 
> {code}
>     private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer, 
> Long>> offsetTable =
>         new ConcurrentHashMap<>(512);
> {code}
> Which is cleaner. 
> Since rocketmq broker require jdk which is greater or higher than java7, this 
> can be improved.
> But rocketmq client should still remains compatible with jdk 1.6



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)