[
https://issues.apache.org/jira/browse/ROCKETMQ-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040638#comment-16040638
]
ASF GitHub Bot commented on ROCKETMQ-215:
-----------------------------------------
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120584108
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/cluster/ClusterListSubCommand.java
---
@@ -113,7 +113,7 @@ private void printClusterMoreStats(final
DefaultMQAdminExt defaultMQAdminExt) th
while (itCluster.hasNext()) {
Map.Entry<String, Set<String>> next = itCluster.next();
String clusterName = next.getKey();
- TreeSet<String> brokerNameSet = new TreeSet<String>();
--- End diff --
I think tools module should be consistent with broker module. There is no
need to maintain low version compatibility.
> Use java 7 syntax to refator code base
> --------------------------------------
>
> Key: ROCKETMQ-215
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-215
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-broker, rocketmq-namesrv, rocketmq-store
> Reporter: Jaskey Lam
> Assignee: yukon
> Priority: Minor
>
> code base may have some code like
> {code}
> private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer,
> Long>> offsetTable =
> new ConcurrentHashMap<String, ConcurrentMap<Integer, Long>>(512);
> {code}
> Atucally, with java7, it can be simplied to
> {code}
> private ConcurrentMap<String/* topic@group */, ConcurrentMap<Integer,
> Long>> offsetTable =
> new ConcurrentHashMap<>(512);
> {code}
> Which is cleaner.
> Since rocketmq broker require jdk which is greater or higher than java7, this
> can be improved.
> But rocketmq client should still remains compatible with jdk 1.6
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
