[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062586#comment-16062586
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-----------------------------------------

Github user lindzh commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/120#discussion_r123936939
  
    --- Diff: client/pom.xml ---
    @@ -37,13 +37,31 @@
                 <groupId>${project.groupId}</groupId>
                 <artifactId>rocketmq-common</artifactId>
             </dependency>
    +
             <dependency>
                 <groupId>org.slf4j</groupId>
                 <artifactId>slf4j-api</artifactId>
             </dependency>
    +
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-lang3</artifactId>
             </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-core</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-api</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-slf4j-impl</artifactId>
    --- End diff --
    
    As log4j is widely used in example,add this test in example will make it 
confused to choose log moudle.


> Client log4j2 logging
> ---------------------
>
>                 Key: ROCKETMQ-224
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-client
>    Affects Versions: 4.1.0-incubating
>         Environment: Jdk 1.7
>            Reporter: lindzh
>            Assignee: Xiaorui Wang
>             Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to