[
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064123#comment-16064123
]
ASF GitHub Bot commented on ROCKETMQ-224:
-----------------------------------------
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r124163160
--- Diff:
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
@@ -35,16 +36,19 @@
private static Logger createLogger(final String loggerName) {
String logConfigFilePath =
- System.getProperty("rocketmq.client.log.configFile",
- System.getenv("ROCKETMQ_CLIENT_LOG_CONFIGFILE"));
+ System.getProperty("rocketmq.client.log.configFile",
+ System.getenv("ROCKETMQ_CLIENT_LOG_CONFIGFILE"));
--- End diff --
Did you use the right code style?
http://rocketmq.apache.org/docs/code-guidelines/
> Client log4j2 logging
> ---------------------
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
> Issue Type: New Feature
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
> Reporter: lindzh
> Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If
> we using log4j2,there is no client log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
