[
https://issues.apache.org/jira/browse/ROCKETMQ-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098549#comment-16098549
]
ASF GitHub Bot commented on ROCKETMQ-106:
-----------------------------------------
Github user TimiLee commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
yukon <[email protected]>于2017年7月24日 周一22:16写道：
> @Jaskey <https://github.com/jaskey> Hi, I want to merge this PR, could
> you plz help us resolve the conflicts?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-rocketmq/pull/66#issuecomment-317436313>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AIhjY7HDDchyxHnC_z93aFE3hzZp7u-Tks5sRKctgaJpZM4MDzt8>
> .
>
That's sure ,my pleasure.tell me the branch
> Add flow control on topic level
> -------------------------------
>
> Key: ROCKETMQ-106
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-106
> Project: Apache RocketMQ
> Issue Type: Wish
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
> Fix For: 4.2.0-incubating
>
>
> *Motivations*
> For current flow control, we can only control on queue level.
> Howerver, the numbers of queue allocated may be dynamic changed. For example,
> I might hope to control that at most 1000 messages can be pulled from broker
> to protect my client. And I have no idea how many queue I am allocated. Maybe
> I will have 5 queue and 5 instances so I set `pullThresholdForQueue`=1000,
> which works as expected when one is fine. But as long as any instances
> crashes, some instances may be allocated more than one queue, which will
> make messages pulled from broker exceed my expectations.
> A configuration of `pullThresholdForTopic` is propably most user hopes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
