[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108349#comment-16108349
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-----------------------------------------

Github user lizhanhui commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515522
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
    @@ -27,16 +28,19 @@
         public static final String CLIENT_LOG_ROOT = "rocketmq.client.logRoot";
         public static final String CLIENT_LOG_MAXINDEX = 
"rocketmq.client.logFileMaxIndex";
         public static final String CLIENT_LOG_LEVEL = 
"rocketmq.client.logLevel";
    +
         private static Logger log;
     
    -    static {
    -        log = createLogger(LoggerName.CLIENT_LOGGER_NAME);
    +    public static Class logClass = null;
    --- End diff --
    
    Add logClass and its getter for test purpose only?


> Client log4j2 logging
> ---------------------
>
>                 Key: ROCKETMQ-224
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-client
>    Affects Versions: 4.1.0-incubating
>         Environment: Jdk 1.7
>            Reporter: lindzh
>            Assignee: Xiaorui Wang
>             Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to