ASF GitHub Bot commented on ROCKETMQ-138:

Github user Jaskey commented on the issue:

    1. I will still suggest resuing ConsistentHashRouter since it has a good 
enough abstraction which will make your selector much cleanner and easier as 
well as extensible(say specified virtual node nums, hash funtions)
    2. I will suggest we expose a more friendly interface for user to use, for 
example , just let user to implement a shardingKey(MessageQueue q) method, the 
`select` method should be hidden since it is not friendly enough in this case 

> Add AuthenticationException class to remove hard coded Aliyun authentication 
> class
> ----------------------------------------------------------------------------------
>                 Key: ROCKETMQ-138
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-remoting
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>             Fix For: 4.1.0-incubating
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used 
> {code}
> catch (Throwable e) {
>                         if 
> (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
>                             .equals(e.getClass().getCanonicalName())) {
>                             PLOG.error("process request exception", e);
>                             PLOG.error(cmd.toString());
>                         }
> {code}
> A common AuthenticationException should be added to identify Authentication 
> failure.  Developers can throw this exception so that remoting component can 
> ignore it

This message was sent by Atlassian JIRA

Reply via email to