[ 
https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118094#comment-16118094
 ] 

ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------

Github user lyy4j commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/138
  
    I agree with you  that ConsistentHashRouter has a good enough abstraction´╝î 
making the code more  cleanner and  extensible. But I think 
SelectMessageQueueByConsistentHash will not  increase the  difficult of the 
using and more  easier  to  understand  and friendly to read comparing with 
using ConsistentHashRouter to implement


> Add AuthenticationException class to remove hard coded Aliyun authentication 
> class
> ----------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-138
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-remoting
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>             Fix For: 4.1.0-incubating
>
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used 
> {code}
> catch (Throwable e) {
>                         if 
> (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
>                             .equals(e.getClass().getCanonicalName())) {
>                             PLOG.error("process request exception", e);
>                             PLOG.error(cmd.toString());
>                         }
> {code}
> A common AuthenticationException should be added to identify Authentication 
> failure.  Developers can throw this exception so that remoting component can 
> ignore it



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to