[
https://issues.apache.org/jira/browse/ROCKETMQ-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139645#comment-16139645
]
ASF GitHub Bot commented on ROCKETMQ-265:
-----------------------------------------
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134937939
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -238,7 +238,7 @@ public void
testGetMessage_withFilterBitMapAndConsumerChanged() {
// sleep to wait for consume queue has been constructed.
try {
- Thread.sleep(1000);
+ Thread.sleep(2001);
--- End diff --
Do we have any method to ensure CQ has been constructed? Sleep is not a
good practice~
> when os crash for some reasons, the broker consume queue’s data maybe repeat,
> consumer can’t pull the latest message, cause message lag
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-265
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-265
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-store
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: yubaofu
> Assignee: yukon
> Priority: Critical
> Labels: bug
> Fix For: 4.2.0-incubating
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> when os crash for some reasons, the broker consume queue’s data maybe repeat,
> consumer can’t pull the latest message, cause message lag
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
