[jira] [Commented] (ROCKETMQ-265) when os crash for some reasons, the broker consume queue’s data maybe repeat, consumer can’t pull the latest message, cause message lag

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139669#comment-16139669
 ] 

ASF GitHub Bot commented on ROCKETMQ-265:
-----------------------------------------

Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/146#discussion_r134940242
  
    --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java 
---
    @@ -446,6 +446,13 @@ private boolean putMessagePositionInfo(final long 
offset, final int size, final
     
                 if (cqOffset != 0) {
                     long currentLogicOffset = mappedFile.getWrotePosition() + 
mappedFile.getFileFromOffset();
    +
    +                if (expectLogicOffset < currentLogicOffset) {
    +                    log.warn("build consume queue idempotent, 
expectLogicOffset: {} currentLogicOffset: {} Topic: {} QID: {} Diff: {}",
    --- End diff --
    
    How to understand the meaning of building consume queue idempotent？


> when os crash for some reasons, the broker consume queue’s data maybe repeat, 
> consumer can’t pull the latest message, cause message lag
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-265
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-265
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-store
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>            Reporter: yubaofu
>            Assignee: yukon
>            Priority: Critical
>              Labels: bug
>             Fix For: 4.2.0-incubating
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> when os crash for some reasons, the broker consume queue’s data maybe repeat, 
> consumer can’t pull the latest message, cause message lag



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)