[
https://issues.apache.org/jira/browse/ROCKETMQ-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144733#comment-16144733
]
ASF GitHub Bot commented on ROCKETMQ-284:
-----------------------------------------
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/160
[ROCKETMQ-284] ExpressionMessageFilter will pass some message.
https://issues.apache.org/jira/browse/ROCKETMQ-284
Solution:
Keep the tagscode transfer into MessageFilter is legal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vsair/incubator-rocketmq ROCKETMQ-284
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 0c9495f2458259bc419872a727403317de18bfb2
Author: vsair <liuxue...@gmail.com>
Date: 2017-08-29T04:39:09Z
[ROCKETMQ-284] Keep the tagscode transfer into MessageFilter is legal.
----
> ExpressionMessageFilter will pass some message
> ----------------------------------------------
>
> Key: ROCKETMQ-284
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-284
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.1.0-incubating
> Reporter: Eric Liu
> Assignee: Eric Liu
> Fix For: 4.2.0-incubating
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> ExpressionMessageFilter will pass some message with tag's hash code less than
> 0.
> This is not correct. After sql filter feature added, the tag's hash code in
> consume queue may be replaced by the address of consume queue ext. And,
> differences between them are:
> 1. Tag's hash code is an integer, values is between Integer.MIN and
> Integer.MAX.
> 2. Address of consume queue ext is a long, values is between Long.MIN and
> Integer.MIN - 1.
> So, actually, they are not conflict.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
