[
https://issues.apache.org/jira/browse/ROCKETMQ-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174179#comment-16174179
]
ASF GitHub Bot commented on ROCKETMQ-256:
-----------------------------------------
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/143#discussion_r140139119
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/plugin/AbstractPluginMessageStore.java
---
@@ -246,4 +247,14 @@ public void setConfirmOffset(long phyOffset) {
public ConsumeQueue getConsumeQueue(String topic, int queueId) {
return next.getConsumeQueue(topic, queueId);
}
+
+ @Override
+ public PutMessageResult putMessages(MessageExtBatch messageExtBatch) {
+ return null;
+ }
--- End diff --
why return null but not next.putMessages(messageExtBatch)
> Manually clean disk to specified watermark with message consuming progress
> considered
> -------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-256
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-256
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-broker, rocketmq-store, rocketmq-tools
> Affects Versions: 4.1.0-incubating
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
