[
https://issues.apache.org/jira/browse/ROCKETMQ-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174180#comment-16174180
]
ASF GitHub Bot commented on ROCKETMQ-256:
-----------------------------------------
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/143#discussion_r140139906
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1392,6 +1397,14 @@ public void run() {
}, 6, TimeUnit.SECONDS);
}
+ @Override
+ public void purge(int watermark, long consumedPhysicalOffset, boolean
force) {
+ cleanCommitLogService.setPurgeForcefullyWhenManual(force);
+ cleanCommitLogService.setDiskSpaceManuallyCleanRatio(watermark /
100.0);
+
cleanCommitLogService.setConsumedPhysicalOffset(consumedPhysicalOffset);
+ cleanCommitLogService.executeDeleteFilesManually();
--- End diff --
This is not thread safe.
How about just delivering the arguments into executeDeleteFilesManually()
directly?
> Manually clean disk to specified watermark with message consuming progress
> considered
> -------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-256
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-256
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-broker, rocketmq-store, rocketmq-tools
> Affects Versions: 4.1.0-incubating
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
