Harbs commented on issue #641: Fix PAYG violations and code debt URL: https://github.com/apache/royale-asjs/issues/641#issuecomment-569613302 I think we're also conflating two things in our minification discussions. The three cases I believe renaming is an issue are: 1. Binding 2. Reflection 3. Modules For binding, the issue is that the closure compiler does not know about these binding expressions to keep the original names. However, the Royale compiler _does_ know about these binding expressions when compiling the MXML. If we pass the responsibility to name keeping to the time of MXML compilation, we can be very specific about which members we prevent renaming on. I'm not that familiar with reflection, but I assume/hope there's a way to deal with that. At the very least, if reflection classes are not used at all, we can know that reflection is not an issue. Modules are obviously only an issue for applications which are compiled as modules. To me, the question is how can we move the logic to determine what needs to be preserved to the time when we can determine it. I think this question deserves thought.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
