Harbs commented on issue #641: Fix PAYG violations and code debt
URL: https://github.com/apache/royale-asjs/issues/641#issuecomment-569622363
 
 
   > If we can save even more later by reducing exports, that's great, but not 
a way to hide the fact that we're adding code that isn't needed.
   
   Of course.
   I'm trying to figure out where the weight is coming from. Here's some data:
   
   Currently HelloWorld is compiling to 102 KB (although I'm sure I was seeing 
98K yesterday). It looks like my changes from yesterday are not applied on this 
computer, so that explains that difference.
   
   Manually removing reflection data gets that number down to 77KB.
   
   Manually removing virtually all exports gets that number down to 53KB. 
However that actually breaks the app. I think the reason for that is because 
besides the cases above, we need exports for event handlers. I think the only 
reason we need `@export`s for that case is because we're calling 
Language.closure, but I might be wrong about this.
   
   Additionally, I see quite a bit of `Vector` code in the minified code. I 
just manually deleted that, and it looks like the `Vector` code in `Language` 
adds about 5KB.
   
   Then there's the "synthType" code. and quite a few `TypeError`s that did not 
used to be there. I don't understand the synthType code, so I don't know what's 
necessary there or why. I wonder if the `TypeError` code can be debug-only.
   
   The dependencies on the goog event code appears to add about 8KB (not 100% 
sure on the exact number yet).
   
   I'm pretty sure, we can get the total code size to under 40KB for HelloWorld 
if we deal with all of these identified issues, and possibly lower.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to