Harbs commented on pull request #1031: URL: https://github.com/apache/royale-asjs/pull/1031#issuecomment-753872129
Quickly looked at the changes and your comments. Some suggestions: Reading styles in JS is very expensive mostly because it often triggers a forced reflow. I assume you are already using the browser profiling tools to see where the bottleneck is, but it's worth mentioning. Very often it's possible to use `requestAnimationFrame` to delay and batch process reading of styles to prevent extra forced reflows. It's also probably possible to make getStyle smarter so it only falls back to reading browser values when necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
