estanglerbm commented on pull request #1031: URL: https://github.com/apache/royale-asjs/pull/1031#issuecomment-753879083
Several of the changes I made did involve DOM attributes that were causing forced reflow (get scrollTop is still an issue, but I don't see how to fully avoid it). And yes, I saw them in the browser profiler. requestAnimationFrame() was already in the scroll handler, and from my quick testing without it, seemed to be necessary for correct results. But the getStyle() issue involves AS code that is recursively looking up the class hierarchy and parent chain (in AS classes). It's not looking at the DOM. (Though, I was going to suggest that's one way of making getStyle() faster; it's not great, but may be better than the current getStyle().) See the discussion on the dev list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
