greg-dove commented on pull request #1056: URL: https://github.com/apache/royale-asjs/pull/1056#issuecomment-761227034
Thanks again, I will check this and probably merge it later today or tomorrow. One thing that could be super helpful is if you could check replacing AMFNetConnection with the AMF0NetConnection code. AMF0NetConnection was not actually intended to be separate, I just added something to get low level calls working with AMF0 when I needed that (it was actually low level actionscript, not Flex code that was being ported), but that code was ultimately intended to swap into AMFNetConnection. It includes the fix you added here and a few other things. I had started trying to address various issues, but was not able to test broadly and had to set the work aside (for some time now, for similar reasons that you have expressed). Because I know others were using remoting, I was hesitant to make substantial changes to the original AMFNetConnection without being sure. But if you swapped AMF0NetConnection code into AMFNetConnection and everything worked, it could be a good verification of things, and because you 'have your head in this stuff' I would welcome your scrutiny of that.... only when/if you get the chance. See comments in commit 5adce5d6f2d51d77489f8bd1442afa91438a877b ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
