SemiConscious commented on pull request #1056: URL: https://github.com/apache/royale-asjs/pull/1056#issuecomment-762125110
Hey Greg - thanks for your help with my pull requests, and that's an excellent idea regarding Java version - I will give it a shot. I have just built my app with AMFNetConnection replaced by AMF0NetConnection and it works out of the box. Would you suggest that I stick with AMF0NetConnection? I was initially concerned by the way that there were no events on AMFNetConnection unlike NetConnection ... then I looked at the NetConnection code and realised they won't actually get fired in JS-land - should that be a concern? On a more general note - I have come to a bit of a crossroads in my port. It currently has MX controls and UI. I seem to be hitting a lot of problems with the MX controls in Royale, mainly unimplemented functionality. I see that Carlos has previously recommended going with Jewel throughout, and I can see many controls in the tour de jewel application that seem to be working versions of things I don't have in MX, eg Tiles. I need to make a decision whether to stay with MX and work around or fix issues as they come up, or do a Jewel conversion. There are 225 mxml files (and another 200 as files) in the project. Do you have a recommendation? All the best Rupert On Fri, 15 Jan 2021 at 22:17, greg-dove <[email protected]> wrote: > Thanks again, I will check this and probably merge it later today or > tomorrow. > > One thing that could be super helpful is if you could check replacing > AMFNetConnection with the AMF0NetConnection code. > AMF0NetConnection was not actually intended to be separate, I just added > something to get low level calls working with AMF0 when I needed that (it > was actually low level actionscript, not Flex code that was being ported), > but that code was ultimately intended to swap into AMFNetConnection. It > includes the fix you added here and a few other things. > I had started trying to address various issues, but was not able to test > broadly and had to set the work aside (for some time now, for similar > reasons that you have expressed). Because I know others were using > remoting, I was hesitant to make substantial changes to the original > AMFNetConnection without being sure. But if you swapped AMF0NetConnection > code into AMFNetConnection and everything worked, it could be a good > verification of things, and because you 'have your head in this stuff' I > would welcome your scrutiny of that.... only when/if you get the chance. > See comments in commit 5adce5d > <https://github.com/apache/royale-asjs/commit/5adce5d6f2d51d77489f8bd1442afa91438a877b> > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/royale-asjs/pull/1056#issuecomment-761227034>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AANMOPVNPZJ72RAD6DCLNLDS2C5HFANCNFSM4WDHM3DQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
