greg-dove commented on pull request #1036: URL: https://github.com/apache/royale-asjs/pull/1036#issuecomment-761270946
Do you have any other changes locally that might not be added to this PR? When I tried switching on the XMLNotitficationTest, I could see all tests passing except the 'testReplaceNode' test. We could add [Ignore] to that test for now. I think you also mentioned at one point that there were issues with the representation of the expected results (iirc - I might be wrong) in the tests, so perhaps you have fixes for that? I'm happy to merge this as-is, but I wanted to check first if there were some additional local changes you had not included here... ? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
