greg-dove commented on pull request #1036: URL: https://github.com/apache/royale-asjs/pull/1036#issuecomment-761277274
Ok, cool, thanks for confirming. I did have that replaceNode test working in the original prototype swapping implementation I started for this (see: https://github.com/apache/royale-asjs/blob/a747d311b819f3263e2a24a27066ffb58a1ad8dd/frameworks/projects/XML/src/main/royale/org/apache/royale/language/NotificationXML.as#L143) , but not sure if anything I did there helps with this approach (and I had not considered bubbling at all when I started looking at that, it was simply swapping the runtime behaviour of instances if they had notification functions assigned). I'll merge this as-is, and switch on all the notification tests except the failing one - thanks again! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
